32 chore fix GitHub actions workflow #34
Closed
+60
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBMskeuxnXKiWCxQXzJyD2
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBMskeuxnXKiWCxQXzJyD2
31 chore extend eslintprettier
anettkva
reviewed
Sep 11, 2026
There was a problem hiding this comment.
Nice fix!
One thing though, looks like this is targeting main instead of dev? Since main is behind dev right now, the diff here is pulling in a bunch of commits that are already merged into dev (eslint fix, prettier reformat, .env gitignore, etc.), even though the actual new change is just the one commit moving/updating the workflow file. Might be worth retargeting the base branch to dev so the diff only shows what's actually new here?
Everything else looks solid, tested npm ci + lint + prettier check locally on this branch and it all passes cleanly.
|
This should not be merged as there are no runners avaliable so they will never pass. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing to see if we can run github pipelines.